On Sat, 30 Mar 2013 10:01:21 +0800
"Michael W. Bombardieri" <m...@ii.net> wrote:
> Hi,
>
> The following patch removes variable 'found' from lookup_feature().
> We can just return true/false (found/not found) directly.
> Does this look OK?
We are aiming to remove lookup_feature() and related feature tables,
so touching it without adding/fixing something looks like unnecessary code
movement.
>
> - Michael
>
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index a0640db..9147aaf 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -319,15 +319,14 @@ static bool lookup_feature(uint32_t *pval, const char
> *s, const char *e,
> {
> uint32_t mask;
> const char **ppc;
> - bool found = false;
>
> for (mask = 1, ppc = featureset; mask; mask <<= 1, ++ppc) {
> if (*ppc && !altcmp(s, e, *ppc)) {
> *pval |= mask;
> - found = true;
> + return true;
> }
> }
> - return found;
> + return false;
> }
>
> static void add_flagname_to_bitmaps(const char *flagname,
>
--
Regards,
Igor
