Hi On Mon, Mar 18, 2013 at 2:11 PM, Alon Levy <[email protected]> wrote: > static void ccid_reset_parameters(USBCCIDState *s) > { > - uint32_t len = sizeof(abDefaultProtocolDataStructure); > - > - s->bProtocolNum = 1; /* T=1 */ > - s->ulProtocolDataStructureSize = len; > - memcpy(s->abProtocolDataStructure, abDefaultProtocolDataStructure, len); > + s->bProtocolNum = 0; /* T=0 */ > + s->abProtocolDataStructure = defaultProtocolDataStructure; > }
You changed default protocol, even if it's a correct change imho, why not make it explicit with a seperate patch? Other than that, it looks great. -- Marc-André Lureau
