Andreas Färber <[email protected]> writes:
> Am 22.02.2013 18:20, schrieb Markus Armbruster:
>> Covers only PC so far.
>>
>> Signed-off-by: Markus Armbruster <[email protected]>
>
> Reviewed-by: Andreas Färber <[email protected]>
>
>> +static void test_cmos_byte(int reg, int expected)
>> +{
>> + int actual;
>> +
>> + outb(0x70 + 0, reg);
>> + actual = inb(0x71);
>
> Did you intend to use 0x70 + 1 here or why the 0x70 + 0 above?
Looks like a pasto to me. Let's drop the stupid '+ 0'.
>> + g_assert_cmphex(actual, ==, expected);
>> +}
>
>> +int main(int argc, char *argv[])
>> +{
>> + g_test_init(&argc, &argv, NULL);
>> +
>> + qtest_add_func("boot-order/pc", test_pc_boot_order);
>> +
>> + return g_test_run();
>> +}
>
> So this is suggesting to me to add separate test functions per arch.
> Fine with me, we'll only have to reindent one line then.
>
> Thanks for the changes,
Hard to predict for me how the tests for other archs will look, and what
could be shared. Add them and see :)
