> -----Original Message----- > From: Stefano Stabellini [mailto:[email protected]] > Sent: Friday, February 22, 2013 8:35 PM > To: Hao, Xudong > Cc: [email protected]; [email protected]; [email protected]; > Stefano Stabellini; [email protected]; Zhang, Xiantao > Subject: Re: [PATCH] qemu: define a TOM register to report the base of PCI > > On Fri, 22 Feb 2013, Xudong Hao wrote: > > Define a TOM(top of memory) register to report the base of PCI memory, > update > > memory region dynamically. > > > > The use case of this register defination is for Xen till now. > > > > Signed-off-by: Xudong Hao <[email protected]> > > Signed-off-by: Xiantao Zhang <[email protected]> > > Thanks for the patch! > > Aside from Jan's comment on the pci config endianness, I would also like > to see an #define somewhere in QEMU to specific what's the default TOM. > In particular I wouldn't want 0xe0000000 (and 0xf0000000) to be > hardcoded in more than one place. > > Good comments, I'll define the default TOM out and replace the hardcode.
Thanks, -Xudong
