On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote: > The only interesting note is the value-copy of EventNotifiers. At least > in my opinion this is part of the EventNotifier API and is even portable > to Windows. Of course, in this case you should not close the notifier's > underlying file descriptors or handle with event_notifier_cleanup.
This is worth a comment in the code. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > hw/dataplane/Makefile.objs | 2 +- > hw/dataplane/event-poll.c | 100 > --------------------------------------------- > hw/dataplane/event-poll.h | 40 ------------------ > hw/dataplane/virtio-blk.c | 41 ++++++++++--------- > 4 files changed, 22 insertions(+), 161 deletions(-) > delete mode 100644 hw/dataplane/event-poll.c > delete mode 100644 hw/dataplane/event-poll.h Looks good aside from what mdroth pointed out. Stefan
