Am 20.02.2013 22:46, schrieb David Woodhouse: > From: David Woodhouse <[email protected]> > > Signed-off-by: David Woodhouse <[email protected]> > --- > hw/piix_pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/piix_pci.c b/hw/piix_pci.c > index 6b69e26..d45449a 100644 > --- a/hw/piix_pci.c > +++ b/hw/piix_pci.c > @@ -301,8 +301,7 @@ static PCIBus *i440fx_common_init(const char *device_name, > pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq); > } > piix3->pic = pic; > - *isa_bus = DO_UPCAST(ISABus, qbus, > - qdev_get_child_bus(&piix3->dev.qdev, "isa.0")); > + *isa_bus = ISA_BUS(qdev_get_child_bus(&piix3->dev.qdev, "isa.0")); > > *piix3_devfn = piix3->dev.devfn; >
Use of ISA_BUS() is correct, but it would be nice to use (DEVICE(piix3), ...) if respun. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
