Il 20/02/2013 19:04, David Woodhouse ha scritto: >> > PCII440FXState *d = I440FX_PCI_WHATEVER_CAST_MACRO_NAME(dev); > Yeah, that's the easy bit. The bit that I'm vaguely confused by would be > something like > > #define I440FX_PCI_WHATEVER_CAST_MACRO_NAME(obj) \ > OBJECT_CHECK(PCII440FXState, (obj), "i440FX") > > Where that "i440FX" should probably be turned into a macro of its own?
Yes, TYPE_PCI_I440FX_STATE. > And then all the *existing* uses of DO_UPCAST should be fixed to use it > too? Such as in i440fx_write_config() ? Yes, that would be helpful. But I would not block your patch for the casts, since i440FX is not yet converted. Paolo
