On 20 February 2013 15:46, Laszlo Ersek <[email protected]> wrote: > On 02/20/13 16:21, Peter Maydell wrote: > >> +#define sigjmp_buf jmp_buf >> +#define sigsetjmp(env, savemask) setjmp(env) >> +#define siglongjmp(env, val) longjmp(env, val) > > Apologies for not really reviewing v1; do you think it would be useful > to add parens around "env" and "val" in the siglongjmp() replacement text?
Fractional increase in clarity perhaps, but it isn't necessary AIUI. > Also, maybe it would be cleaner to replace these windows-oriented > #defines with a commonly used, new set of macros that would expand to > sig* and ", 0" on non-windows, and to the current text on windows. I thought about that but I think in general we should prefer to just use the POSIX interface when one is available, with fixups for non-POSIX platforms. (I don't feel hugely strongly either way, though.) -- PMM
