Seiji Aguchi <seiji.agu...@hds.com> writes: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we often need to know when the problem happens. > > But, currently, there is no timestamp in qemu's error messages. > Therefore, we may not be able to understand the problem based on > error messages. > > [Solution] > This patch adds a timestamp to qemu's error message logged by > error_report(). > > A logic calculating a time is copied from libvirt, src/util/virtime.c.
Do we really want to add timestamps to error messages unconditionally? I don't doubt it's useful in your scenario, but most of the time it's just annoying clutter. > [TODO] > Other functions below are used to output error messages in qemu. > - qerror_report() is called in many source codes. Not a problem, it ends up in qerror_print(), which calls error_report(). > - fprintf() is called in vl.c. All over the place, not just vl.c. Also monitor_printf(). > A timestamp should be added to these messages as well. [...]
