Re: [Qemu-devel] [PATCH V2 2/6] hw/mdio: Generalize etraxfs MDIO bitbanging emulation

[Paul Brook]

> +#ifdef USE_THIS_DEAD_CODE
> +void mdio_detach(struct qemu_mdio *bus, struct qemu_phy *phy, unsigned int
> addr) +{
> +    bus->devs[addr & 0x1f] = NULL;
> +}
> +#endif

This is clearly wrong.


It also worries me that there isn't a clean separation between the MDIO bus 
and the bitbang interface.  IMO the bitbang interface should be a separate 
device, and if we're wiring up bitbang interfaces then it really should be via 
standard GPIO pins (aka qemu_irq). 

Paul