Re: [Qemu-devel] [PATCH V4 1/4] HMP: add QDict to info callback handler

[Wenchao Xia]

于 2013-1-10 21:10, Luiz Capitulino 写道:

On Thu, 10 Jan 2013 16:32:31 +0800
Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:

diff --git a/monitor.c b/monitor.c
index 9cf419b..c7b3014 100644
--- a/monitor.c
+++ b/monitor.c
@@ -123,7 +123,7 @@ typedef struct mon_cmd_t {
      const char *help;
      void (*user_print)(Monitor *mon, const QObject *data);
      union {
-        void (*info)(Monitor *mon);
+        void (*info)(Monitor *mon, const QDict *qdict);
          void (*cmd)(Monitor *mon, const QDict *qdict);

Is it possible to eliminate 'info' and use 'cmd' instead?

  yes, now info is not a special case but a sub command.
If you agree I'll delete info function.

--
Best Regards

Wenchao Xia