On Fri, Jan 11, 2013 at 12:07:40AM +0100, Igor Mammedov wrote:
[...]
> > @@ -1343,13 +1337,15 @@ static int cpu_x86_parse_featurestr(x86_def_t
> > *x86_cpu_def, char *features)
> > unsigned int i;
> > char *featurestr; /* Single 'key=value" string being parsed */
> > /* Features to be added */
> > - FeatureWordArray plus_features = {
> > - [FEAT_KVM] = kvm_default_features,
> > - };
> > + FeatureWordArray plus_features = { 0 };
> > /* Features to be removed */
> > FeatureWordArray minus_features = { 0 };
> > uint32_t numvalue;
> >
> > + if (kvm_enabled()) {
> > + plus_features[FEAT_KVM] = kvm_default_features;
> > + }
> While touching it please move setting defaults to cpu_x86_register() or
> cpu_x86_find_by_name() to so that cpu_x86_parse_featurestr() would deal only
> with custom settings.
OK, I will do it in the next version.
--
Eduardo