On 01/10/2013 07:39 AM, Paolo Bonzini wrote: > A blank CD or DVD is visible as a zero-sized disks. Probing such > disks will lead to an EIO and a failure to start the VM. Treating > them as raw is a better solution. > > Signed-off-by: Paolo Bonzini <[email protected]> > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index c05875f..b9da10e 100644 > --- a/block.c > +++ b/block.c > @@ -532,7 +532,7 @@ static int find_image_format(const char *filename, > BlockDriver **pdrv) > } > > /* Return the raw BlockDriver * to scsi-generic devices or empty drives > */ > - if (bs->sg || !bdrv_is_inserted(bs)) { > + if (bs->sg || !bdrv_is_inserted(bs) || bdrv_getlength(bs) == 0) {
Do we need to extend this to all files with size smaller than the length of the header used in probing to determine a non-raw file? Or is the case of someone passing a 1-byte file as a backing file of a device too unlikely, where refusing to start the VM is okay for that case? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
