> > We should also merge functionality of migrations and vm-snapshots and make > some clean-ups of this code. I could do it as another patch. With this > rewrite we could make vm-snapshots asynchronous. > > Hi, Pavel For vm-snapshots asynchronous, I have sent a RFC patch for it at: http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg00800.html
and seems diet...@proxmox.com also have his own solution at: https://git.proxmox.com/?p=pve-qemu-kvm.git;a=blob;f=debian/patches/internal-snapshot-async.patch; So I am reworking on it to include Dietmar's solution, My plan will include three steps: 1) abstract a function for internal/external snapshots(block only). 2) abstract a function for internal/external live vmstate save. 3) assemble above functions at will at above layer. patch for 1) is sent at http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg02393.html I agree that code should be merged as much as possible, just hope my patch wouldn't conflict with yours patch about vmstate save. For vmstate it have a issue about how to limit the file size to be written, that is predict the size to write. We may need a discuss about that.
