Am 08.12.2012 17:08, schrieb Peter Maydell: > On 8 December 2012 14:48, Andreas Färber <[email protected]> wrote: >> Shouldn't we be updating the Coding Style on all lines we touch? The >> shift line matches it but the normalize and ifs don't. > > fpu/ is a special case because the softfloat library has such > a bonkers coding style. I tend to update to qemu standard when > I touch bits of it, but following the existing practice is > also OK in my opinion.
The same applies to linux-user and much of ppc code (spaces before parenthesis, no braces). The only agreed-on way to address this is by fixing the parts we touch - no veto here, but seems trivial enough to fix. Otherwise the situation won't ever improve. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
