On 2 December 2012 17:14, Antoine Mathys <[email protected]> wrote:
> Per the datasheet, the mapping between 12 and 24 hours modes is:
>     0      <->  12   PM
>     1-12   <->  1-12 AM
>     13-23  <->  1-11 PM
>
> Signed-off-by: Antoine Mathys <[email protected]>

This looks good as far as the logic goes, but I think we
could use some symbolic constants for the 12-hour and PM
bits rather than all the literal 0x20 0x40 0x60.

thanks
-- PMM

Reply via email to