Am 22.11.2012 16:31, schrieb Eduardo Habkost:
> When adding the Haswell CPU model, I intended to make it a superset of the
> features present on the SandyBridge model, but I have removed the SEP and
> RDTSCP features from the feature list by mistake. This patch adds the missing
> SEP and RDTSCP features (that are present on SandyBridge) to Haswell.
> 
> Reported-by: Martin Kletzander <[email protected]>
> Signed-off-by: Eduardo Habkost <[email protected]>

Acked-by: Andreas Färber <[email protected]>

FWIW this is showing where QOM's imperative approach combined with
inheritance could greatly simplify things beyond your subclasses RFC.
Unfortunately I am not intimately familiar with all these models, so
counting on your help there. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Reply via email to