Hi, > There still has to be a way to share the Property[] array (currently > contains maxframes). Duplicating the properties array to all > definitions is verbose and fragile. If I want to add a new properties > to EHCI i need to put it in the props array of every subclass. serial > has this problem, with the "chardev" prop appearing in both isa and > pci variants (and the device variant out of tree that Anthony has). If > we decide to add a new prop to serial we have to DEFINE_PROP_FOO it 3 > times.
> Whats the real answer here? Can we get the shared init function to add > to properties explicify? Blow away the dc->properties = foo and > replace with code that parses to prop array? Existing practice is to use a #define for that, see DEFINE_NIC_PROPERTIES in net.h for example. Maybe QOM allows us to do something more elegant here. cheers, Gerd
