On 25 October 2012 09:47, Max Filippov <[email protected]> wrote: > @@ -272,37 +273,23 @@ static void lx_init(const LxBoardDesc *board, > static void xtensa_lx60_init(QEMUMachineInitArgs *args) > { > ram_addr_t ram_size = args->ram_size; > - const char *cpu_model = args->cpu_model; > - const char *kernel_filename = args->kernel_filename; > - const char *kernel_cmdline = args->kernel_cmdline; > - const char *initrd_filename = args->initrd_filename; > - const char *boot_device = args->boot_device; > static const LxBoardDesc lx60_board = { > .flash_size = 0x400000, > .flash_sector_size = 0x10000, > .sram_size = 0x20000, > }; > - lx_init(&lx60_board, ram_size, boot_device, > - kernel_filename, kernel_cmdline, > - initrd_filename, cpu_model); > + lx_init(&lx60_board, ram_size, args); > } > > static void xtensa_lx200_init(QEMUMachineInitArgs *args) > { > ram_addr_t ram_size = args->ram_size; > - const char *cpu_model = args->cpu_model; > - const char *kernel_filename = args->kernel_filename; > - const char *kernel_cmdline = args->kernel_cmdline; > - const char *initrd_filename = args->initrd_filename; > - const char *boot_device = args->boot_device; > static const LxBoardDesc lx200_board = { > .flash_size = 0x1000000, > .flash_sector_size = 0x20000, > .sram_size = 0x2000000, > }; > - lx_init(&lx200_board, ram_size, boot_device, > - kernel_filename, kernel_cmdline, > - initrd_filename, cpu_model); > + lx_init(&lx200_board, ram_size, args); > }
Why not let lx_init() pull the ram_size out of args->ram_size as well? -- PMM
