On 10/23/2012 01:51 PM, Paolo Bonzini wrote:
> Il 22/10/2012 11:38, Avi Kivity ha scritto:
>>> >
>>> > typedef struct MemoryRegionOps MemoryRegionOps;
>>> > typedef struct MemoryRegion MemoryRegion;
>>> > @@ -66,6 +67,8 @@ struct MemoryRegionOps {
>>> > target_phys_addr_t addr,
>>> > uint64_t data,
>>> > unsigned size);
>>> > + int (*ref)(MemoryRegion *mr);
>>> > + void (*unref)(MemoryRegion *mr);
>>> >
>> Why return an int? Should succeed unconditionally. Please fold into 7
>> (along with 6).
>
> So the stop_machine idea is thrown away?
IIRC I convinced myself that it's just as bad.
> I really believe we're going
> down a rat's nest with reference counting.
There will be a lot of teething problems, but the same ideas are used
extensively in the kernel.
--
error compiling committee.c: too many arguments to function
