Il 12/10/2012 18:54, Paolo Bonzini ha scritto:
> Il 12/10/2012 14:39, Gerd Hoffmann ha scritto:
>> + chr = qemu_chr_new_from_opts(opts, NULL);
>> + if (chr == NULL) {
>> + qemu_opts_del(opts);
>> + error_setg(&err, "Creating chardev failed\n");
>> + goto exit_err;
>> + }
>> + return 0;
>> +
>
> Since you have to do a v3, please make this part (which is common
> between HMP and QMP) a separate function.
Also please make qemu_chr_new_from_opts use an Error ** at least for the
error that are reported from that function itself (no need to add
propagation to all of qemu-char.c, and it would conflict badly with the
series that does so for qemu-sockets.c).
Paolo
