On 10/04/2012 04:16 PM, Anthony Liguori wrote: > Paolo Bonzini <[email protected]> writes: > >> Il 03/10/2012 18:03, Avi Kivity ha scritto: >>> Most of the work on the memory API focused on memory access targets - the >>> memory regions >>> and how they are composed into an address space. This patchset tackles the >>> initator >>> side of the question - how to originate accesses. >>> >>> The AddressSpace object, is exported to users and becomes the >>> representation of an >>> initiator. Each address space describes the paths from some point in the >>> system >>> (a device or cpu) to the devices reachable from that initiator. >>> >>> As an example, the API is used to support PCI_COMMAND_MASTER bit. >> >> Very nice, IMHO patches 1-18 should get in soon. They are a useful >> cleanup on their own. > > Yup, other than a few minor cosmetics, the series is a very nice > cleanup. > > I think this probably gets us fairly close to being able to write unit > tests for the memory layer too which is really nice.
It still hardcodes the call to address_space_init_dispatch(). But I guess we don't have to be purists and we can have the test framework supply an alternate version of this function. -- error compiling committee.c: too many arguments to function
