Il 02/10/2012 12:43, Juan Quintela ha scritto: > Paolo Bonzini <pbonz...@redhat.com> wrote: >> Il 21/09/2012 14:17, Paolo Bonzini ha scritto: >>> >>> - QLIST_FOREACH(block, &ram_list.blocks, next) { >>> - for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) { >>> - if (!memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE, >>> - DIRTY_MEMORY_MIGRATION)) { >>> - memory_region_set_dirty(block->mr, addr, TARGET_PAGE_SIZE); >>> - } >>> - } >>> - } >>> - >>> memory_global_dirty_log_start(); >>> + memory_global_sync_dirty_bitmap(get_system_memory()); > > With the part of moving it after the memory_global_dirty_log_start() I > agree. > > With the other suggestion, I will take another look at it. The problem > is that vga code can also sync the kvm bitmap, and we want to get that > notifications also.
I think I had replied to myself later... in any case, nothing that cannot be improved after merging. Thanks! Paolo