Luiz Capitulino <[email protected]> writes: > On Tue, 25 Sep 2012 13:29:32 +0200 > Markus Armbruster <[email protected]> wrote: > >> Luiz Capitulino <[email protected]> writes: >> >> > Also fixes a few issues while there: >> > >> > 1. The fd returned by monitor_get_fd() leaks in most error conditions >> > 2. monitor_get_fd() return value is not checked. Best case we get >> > an error that is not correctly reported, worse case one of the >> > functions using the fd (with value of -1) will explode >> > 3. A few error conditions aren't reported >> >> 4. We now "use up" @fdname always. Before, it was left alone for >> invalid @protocol. > > By "uses up" you mean that the fd will be consumed from the monitor's > poll? I guess that's true for every command that accepts fds.
Yes, that's how these commands should work. Before your patch, add_graphics_client() doesn't call when protocol is invalid. Your patch fixes that. Worth mentioning in the commit message. [...]
