Am 21.09.2012 14:54, schrieb Paolo Bonzini:
> Il 21/09/2012 10:47, Juan Quintela ha scritto:
>> Old code used !io_thread to know if a thread was an vcpu or not. That
>> fails when we introduce the iothread.
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> ---
>> cpus.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/cpus.c b/cpus.c
>> index e476a3c..1b7061a 100644
>> --- a/cpus.c
>> +++ b/cpus.c
>> @@ -902,6 +902,11 @@ int qemu_cpu_is_self(void *_env)
>> return qemu_thread_is_self(cpu->thread);
>> }
>>
>> +static bool qemu_cpu_is_vcpu(void)
>> +{
>> + return cpu_single_env && qemu_cpu_is_self(&cpu_single_env);
>
> Should be "cpu_single_env && qemu_cpu_is_self(&cpu_single_env)".
"cpu_single_env && qemu_cpu_is_self(cpu_single_env)" maybe?
> Please named the function qemu_in_vcpu_thread.
Seconded, it does not take a CPU argument.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
