Luiz Capitulino <lcapitul...@redhat.com> writes:
> On Tue, 18 Sep 2012 13:13:16 -0600
> Eric Blake <ebl...@redhat.com> wrote:
>
>> On 09/18/2012 01:06 PM, Luiz Capitulino wrote:
>> > Also fixes a few issues while there:
>> >
>> > 1. The fd returned by monitor_get_fd() leaks in most error conditions
>> > 2. monitor_get_fd() return value is not checked. Best case we get
>> > an error that is not correctly reported, worse case one of the
>> > functions using the fd (with value of -1) will explode
>> > 3. A few error conditions aren't reported
>> >
>> > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com>
>> > ---
>> > monitor.c | 39 ---------------------------------------
>> > qapi-schema.json | 23 +++++++++++++++++++++++
>> > qmp-commands.hx | 5 +----
>> > qmp.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>> > 4 files changed, 68 insertions(+), 43 deletions(-)
>> >
>>
>> > { 'command': 'screendump', 'data': {'filename': 'str'} }
>> > +
>> > +##
>> > +# @add_client
[...]
>> If this were a new command for 1.3, I'd say to name it 'add-client'; but
>> since QMP has already been exposing it and you are now just documenting
>> it, you can't change the name.
>
> Yes, we just have to live with that for all old commands.
If the inconsistency bothers us, we can either
* add suitable aliases for every QMP name containing '_', or
* fix the QMP names, and fold '_' to '-' in names received from client.
