Am 03.09.2012 22:13, schrieb Stefan Weil: > Report from smatch: > hw/ide/core.c:1472 ide_exec_cmd(423) error: buffer overflow > 'smart_attributes' 8 <= 29 > hw/ide/core.c:1474 ide_exec_cmd(425) error: buffer overflow > 'smart_attributes' 8 <= 29 > hw/ide/core.c:1475 ide_exec_cmd(426) error: buffer overflow > 'smart_attributes' 8 <= 29 > ... > > The upper limit of 30 was never reached because both for loops terminated > when 'smart_attributes' reached end of list, so there was no real buffer > overflow. > > Nevertheless, changing the code not only fixes the error report, but also > reduces the size of smart_attributes and simplifies the for loops. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > > Note: scripts/checkpatch.pl reports warnings and errors caused by tabs and > wrong indentation. I did not fix that because the whole file is full of tabs. > > - sw
Thanks, applied to block-next. Kevin
