Eric Blake <ebl...@redhat.com> writes:
> On 08/22/2012 11:14 PM, Lei Li wrote:
>> Signed-off-by: Lei Li <li...@linux.vnet.ibm.com>
>
> Subject line uses '_', but the QMP command uses '-' [1]
>
>> ---
>> hmp-commands.hx | 16 ++++++++++++++++
>> hmp.c | 15 +++++++++++++++
>> hmp.h | 1 +
>> qapi-schema.json | 28 ++++++++++++++++++++++++++++
>> qemu-char.c | 36 ++++++++++++++++++++++++++++++++++++
>> qmp-commands.hx | 33 +++++++++++++++++++++++++++++++++
>> 6 files changed, 129 insertions(+), 0 deletions(-)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index f6104b0..829aea1 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -797,6 +797,22 @@ Inject an NMI on the given CPU (x86 only).
>> ETEXI
>>
>> {
>> + .name = "memchar-write",
>
> HMP commands should use '_', not '-'.
Both '_' and '-' occur in HMP command names. There are more occurences
of '_', though.
Otherwise identical HMP and QMP commands differing only in '_' vs. '-'
is ugly. Maybe we should simply map '_' in HMP command names to '-' and
be done with it.
[...]
