On 24.08.2012, at 09:28, Jason Baron wrote: > On Thu, Aug 09, 2012 at 10:49:23AM -0400, Jason Baron wrote: >> On Thu, Aug 09, 2012 at 02:59:54PM +0200, Andreas Färber wrote: >>> Define generic VMState for AHCI and reuse it together with PCI for ICH >>> and on its own for the SysBus version. >>> >>> Note: ICH9 initializes AHCI with 6 ports, which dynamically allocates >>> 6 AHCIDevice structs. Thus we change the ports field type to uint32_t >>> for compatibility with VMState macros. >>> >>> Signed-off-by: Andreas Färber <[email protected]> >>> Cc: Alexander Graf <[email protected]> >>> Cc: Jason Baron <[email protected]> >>> Cc: Kevin Wolf <[email protected]> >>> Cc: Juan Quintela <[email protected]> >>> Cc: Igor Mitsyanko <[email protected]> >>> --- >>> hw/ide/ahci.c | 46 +++++++++++++++++++++++++++++++++++++++++++++- >>> hw/ide/ahci.h | 12 +++++++++++- >>> hw/ide/ich.c | 11 ++++++++--- >>> 3 files changed, 64 insertions(+), 5 deletions(-) >>> >> >> Thanks for doing this. My migration on q35 completes, but the disk is >> not accessible. Didn't test piix. Console output below. >> > > Hi Andreas, > > The below patch (ont top of you patch) makes ahci migration work for me, very > lightly tested at this point.
Since you have a version of the migration that works, how about posting the whole thing as non-RFC? :) Alex
