Am 02.08.2012 18:22, schrieb Peter Maydell:
> On 2 August 2012 17:01, Andreas Färber <[email protected]> wrote:
>> One minor nit: The indentation seems off here - esac 2 spaces, if 4.
>
> configure's indentation is pretty inconsistent generally between
> 2 or 4 spaces. I usually go for 4 for new code but don't reindent
> old code. (There's a lot more 2-space than 4-space I think but
> 4 is the qemu coding style :-))
A matter of interpretation, I see our Coding Style as applying to C
code, not strictly to shell or Python or Perl code.
Why I pointed this out is because that's effectively like writing:
...
}
if (foo) {
...
}
}
So could you please either use 2-space indentation for your inserted if
or re-indent the case block above, so that there is not this break?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
