Two hairs to split:
On 07/20/12 14:01, Stefan Hajnoczi wrote:
> +static NetHubPort *net_hub_port_new(NetHub *hub, const char *name)
> +{
> + VLANClientState *nc;
> + NetHubPort *port;
> + unsigned int id = hub->num_ports++;
There are projects that don't like to put logic or externally visible
side-effects into initializers. I don't know about qemu.
> diff --git a/qapi-schema.json b/qapi-schema.json
> index bc55ed2..6618eb5 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -2094,6 +2094,19 @@
> '*helper': 'str' } }
>
> ##
> +# @NetdevHubPortOptions
> +#
> +# Connect two or more net clients through a software hub.
> +#
> +# @hubid: hub identifier number
> +#
> +# Since 1.2
> +##
> +{ 'type': 'NetdevHubPortOptions',
> + 'data': {
> + 'hubid': 'int' } }
I think this should say 'uint32'.
Thanks,
Laszlo
