On 07/18/2012 08:31 AM, Gerd Hoffmann wrote:
> 'make dist' creates a tarball for the current checkout.
> 'make qemu-${version}.tar.bz2' creates a tarball for git tag v${version}.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> Makefile | 5 ++---
> scripts/make-release | 8 +++++++-
> 2 files changed, 9 insertions(+), 4 deletions(-)
> +++ b/scripts/make-release
> @@ -12,11 +12,17 @@
>
> src="$1"
> version="$2"
> +if test "$version" = ""; then
test ! "$version"
is less typing, and still POSIX compliant.
> + commit=$(git describe --long)
> + version="${commit#v}"
Sticking with my earlier theme started against Anthony's original
implementation of this script, in complaining about inconsistent shell
quoting styles, it might look nicer to favor minimal quoting:
commit=$(git describe --long)
version=${commit#v}
or maximal quoting:
commit="$(git describe --long)"
version="${commit#v}"
rather than an ad hoc mix. But as that is cosmetic, and does not impact
functionality, you have my:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
