On 12 July 2012 01:45, Peter Crosthwaite <[email protected]> wrote: > On Tue, Jul 10, 2012 at 11:32 PM, Peter Maydell wrote: >> I still think that having this new function is misguided: >> * nobody's using it > > I wasn't thinking a new dead function. I was suggesting that the one > function you originally proposed was generalised to handle non zero > offsets. Only a small change to what you originally had. Lets not > think about this now though, as its not worth blocking your series > over dead code.
Thanks; I appreciate the pragmatism. Do you want to add a reviewed-by: tag to my v1 patch, then, or was there something else that I need to change in it? > Ill fix incrementally when the time comes for me to > push my own dtb work that needs this functionality. But having to > query the whole DTB cell array to get a single property will make a > mess of my code. Mmm. It'll probably be easier to assess the new/changed API in the context of something using it anyway. thanks -- PMM
