On 07/05/2012 05:14 PM, Eric Blake wrote:
> On 07/05/2012 06:51 AM, Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Benoit Hudzia <[email protected]>
>> Signed-off-by: Petter Svard <[email protected]>
>> Signed-off-by: Aidan Shribman <[email protected]>
>> Signed-off-by: Orit Wasserman <[email protected]>
>> ---
>
>> + {
>> + .name = "migrate_set_cachesize",
>> + .args_type = "value:o",
>> + .params = "value",
>> + .help = "set cache size (in bytes) for XBZRLE migrations,"
>> + "the cache size will be rounded down to the nearest "
>> + "power of 2.\n"
>> + "The cache size effects the number of cache misses."
>> + "In case of a high cache miss ratio you need to increase
>> the cache size",
>
> Inconsistent indentation. Kill those TABs.
>
>> +++ b/migration.c
>> @@ -22,6 +22,7 @@
>> #include "qemu_socket.h"
>> #include "block-migration.h"
>> #include "qmp-commands.h"
>> +#include <math.h>
>
> Urgh. You STILL haven't killed this bogus include, even though I've
> been mentioning it since my v12 review. I'm really getting frustrated
> with how long this series is being dragged out.
Again I'm really sorry I will be more careful next time
Thanks,
Orit
>
>>
>> //#define DEBUG_MIGRATION
>>
>> @@ -43,7 +44,7 @@ enum {
>>
>> #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */
>>
>> -/* Migration XBZRLE cache size */
>> +/* Migration XBZRLE default cache size */
>
> Again from my v12 review, this hunk should be squashed into the patch
> that first introduces the comment.
>
>> +migrate_set_cachesize
>> +---------------------
>> +
>> +Set cache size to be used by XBZRLE migration, the cache size will be round
>> down
>> +to the nearset power of 2
>
> Another v12 review leftover:
>
> s/nearset/nearest/
>
