On Thu, Feb 26, 2026 at 03:20:34PM +0000, Alireza Sanaee wrote:
> + /*
> + * Optimization: Looking for a fully committed path; if the type 3
> HDM
> + * decoder is not commmitted, it cannot lie on such a path.
^^^ committed
... snip ...
> + object_child_foreach_recursive(object_get_root(),
> + cxl_fmws_direct_passthrough,
> + &state);
> + }
> + }
> + dpa_base += decoder_size / cxl_interleave_ways_dec(iw, &error_fatal);
> + }
> +
Div-by-0 here for invalid values?
int cxl_interleave_ways_dec(uint8_t iw_enc, Error **errp)
{
switch (iw_enc) {
... snip ...
default:
error_setg(errp, "Encoded interleave ways: %d not supported", iw_enc);
return 0;
}
}
Or does this abort before return?
> + return false;
> +}
You're returning false as an 'int'
~Gregory
