On Thu, 5 Mar 2026 at 11:33, Daniel P. Berrangé <[email protected]> wrote: > > On Thu, Mar 05, 2026 at 11:18:32AM +0000, Peter Maydell wrote: > > Here's a patch that takes the "just work around this one problem" > > approach to the gcc sanitizer compile failure. > > The alternative is a "#pragma push" to temp disable the > -Wstringop-overflow warning, though that would need to be > done in the 2 code locations triggering the bogus warning, > instead of this which does the single code location that > first confuses GCC, leading to the later warnings. I don't > mind either way though so...
I preferred not to do that, partly beacuse the warning is triggered in three places, and partly because this code's use of memcpy() is pretty confusing to me and I'd rather we kept the warning enabled on those calls if we can, so we don't accidentally silence any genuine overrun bugs here. thanks -- PMM
