This series consists of cosmetic changes around TYPE_SERIAL. The biggest change
is having it derive from TYPE_SYS_BUS_DEVICE which 1) eliminates usage of
qemu_{un,}register_reset() and 2) stops all its users from accessing private
data. The latter allows TYPE_SERIAL to be ported to Rust in the (near) future.
v2:
* Pick up R-b tags. Thanks!
* Ad patch to free consumers of TYPE_SERIAL from setting up MemoryRegionOps;
configure via properties instead which should resolve odd code (Peter)
* Improve wording in one commit message (Peter)
* Sort patches by moving char/serial last
-> Keep "Avoid implicit conversion when tracing" untouched for now. Can be
omitted if deemed inappropriate.
Testing done:
* Make check
* Boot mpc8544ds machine with Linux and interact with it on the serial console
* Boot q35 machine with Arch Linux and interact with it on the serial console
Bernhard Beschow (13):
hw/arm/Kconfig: Fix serial selection for NPCM8XX
hw/arm/aspeed_ast27x0-{ssp, tsp}: Do not access SerialMM internals
directly
util/fifo8: Make all read-only methods const-correct
hw/char/serial: Remove explicit cast from void pointer
hw/char/serial: Prefer fifo8 methods over open-coding
hw/char/serial: Reuse fifo8_num_used()
hw/char/serial: Remove stale comment
hw/char/serial: Add constants for Line Control Register
hw/char/serial: Remove redundant reset
hw/char/serial: Avoid implicit conversion when tracing
hw/char/serial: Keep MemoryRegionOps private
hw/char/serial: Inherit from SysBusDevice
hw/char/serial: Plug into reset framework
include/hw/char/serial-mm.h | 3 -
include/hw/char/serial.h | 8 ++-
include/qemu/fifo8.h | 10 +--
hw/arm/aspeed_ast27x0-ssp.c | 7 +-
hw/arm/aspeed_ast27x0-tsp.c | 7 +-
hw/char/diva-gsp.c | 23 +++---
hw/char/serial-isa.c | 17 +++--
hw/char/serial-mm.c | 59 ++--------------
hw/char/serial-pci-multi.c | 23 +++---
hw/char/serial-pci.c | 11 ++-
hw/char/serial.c | 137 +++++++++++++++++++++++++-----------
util/fifo8.c | 10 +--
hw/arm/Kconfig | 2 +-
hw/char/trace-events | 4 +-
14 files changed, 157 insertions(+), 164 deletions(-)
--
2.53.0
