From: Marc-André Lureau <[email protected]> Type annotations allow easier code reading, refactoring, checking etc.
Reviewed-by: Yodel Eldar <[email protected]> Tested-by: Yodel Eldar <[email protected]> Acked-by: Mark Cave-Ayland <[email protected]> Reviewed-by: Akihiko Odaki <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]> --- scripts/modinfo-generate.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/scripts/modinfo-generate.py b/scripts/modinfo-generate.py index aaf23544c46..5a8abcae5d3 100644 --- a/scripts/modinfo-generate.py +++ b/scripts/modinfo-generate.py @@ -2,14 +2,16 @@ import os import sys +from typing import Optional -def print_array(name, values): + +def print_array(name: str, values: list[str]) -> None: if len(values) == 0: return list = ", ".join(values) print(" .%s = ((const char*[]){ %s, NULL })," % (name, list)) -def parse_line(line): +def parse_line(line: str) -> tuple[str, str]: kind = "" data = "" get_kind = False @@ -31,7 +33,7 @@ def parse_line(line): continue return (kind, data) -def generate(name, lines, enabled): +def generate(name: str, lines: list[str], enabled: set[str]) -> Optional[set[str]]: arch = "" objs = [] deps = [] @@ -68,17 +70,17 @@ def generate(name, lines, enabled): print("},{") return {dep.strip('" ') for dep in deps} -def print_pre(): +def print_pre() -> None: print("/* generated by scripts/modinfo-generate.py */") print("#include \"qemu/osdep.h\"") print("#include \"qemu/module.h\"") print("const QemuModinfo qemu_modinfo[] = {{") -def print_post(): +def print_post() -> None: print(" /* end of list */") print("}};") -def main(args): +def main(args: list[str]) -> None: if len(args) < 3 or args[0] != '--devices': print('Expected: modinfo-generate.py --devices ' 'config-device.mak [modinfo files]', file=sys.stderr) -- 2.53.0
