From: Peter Xu <[email protected]> COLO (in case of periodically checkpointing) already have switchover happened before hand. This switchover_start feature never applies to COLO.
Savevm for snapshot doesn't have switchover phase and VM is stopped for the whole process. Remove both. Signed-off-by: Peter Xu <[email protected]> Reviewed-by: Fabiano Rosas <[email protected]> Tested-by: Lukas Straub <[email protected]> Link: https://lore.kernel.org/qemu-devel/[email protected] Signed-off-by: Fabiano Rosas <[email protected]> --- migration/colo.c | 2 -- migration/savevm.c | 1 - 2 files changed, 3 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index e05736ecf0..c344943173 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -453,8 +453,6 @@ static int colo_do_checkpoint_transaction(MigrationState *s, goto out; } - qemu_savevm_maybe_send_switchover_start(s->to_dst_file); - /* Note: device state is saved into buffer */ ret = qemu_save_device_state(fb); diff --git a/migration/savevm.c b/migration/savevm.c index 529cf310e0..d41be3a4a2 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1830,7 +1830,6 @@ static int qemu_savevm_state(QEMUFile *f, Error **errp) ret = qemu_file_get_error(f); if (ret == 0) { - qemu_savevm_maybe_send_switchover_start(f); qemu_savevm_state_complete_precopy(f, false); ret = qemu_file_get_error(f); } -- 2.51.0
