On Tue, Feb 10, 2026 at 03:41:48PM +0100, BALATON Zoltan wrote: > Date: Tue, 10 Feb 2026 15:41:48 +0100 > From: BALATON Zoltan <[email protected]> > Subject: Re: [PATCH v2 03/21] qom/object: factor out > object_class_property_try_add() > > On Tue, 10 Feb 2026, Zhao Liu wrote: > > Similar to object_property_try_add(), factor out > > object_class_property_try_add(). > > > > This allows adding more arguments to the core implementation without > > changing the signature of object_class_property_add(), avoiding the > > need to modify the extensive number of callers distributed throughout > > the code tree. > > > > While at it, add documentation for these functions. > > > > Signed-off-by: Zhao Liu <[email protected]> > > --- > > include/qom/object.h | 56 ++++++++++++++++++++++++++++++++++++++++++++ > > qom/object.c | 34 ++++++++++++++++++++------- > > 2 files changed, 82 insertions(+), 8 deletions(-) > > > > diff --git a/include/qom/object.h b/include/qom/object.h > > index 05706d4d7e3a..060db136988b 100644 > > --- a/include/qom/object.h > > +++ b/include/qom/object.h > > @@ -1147,6 +1147,62 @@ ObjectProperty *object_property_add(Object *obj, > > const char *name, > > > > void object_property_del(Object *obj, const char *name); > > > > +/** > > + * object_class_property_try_add: > > This is renamed two patches later so maybe should be named like that here > and drop the renaming patch.
Indeed, these two patches seem trivial, but I still prefer to separate the renaming patch. Reviewing patches related to renaming is always straightforward and maybe relaxing. :) Thanks, Zhao
