On 2026/02/06 6:25, Michael Tokarev wrote:
On 10/27/25 04:24, Akihiko Odaki wrote:
Children are automatically unparented so manually unparenting is
unnecessary.
Worse, automatic unparenting happens before the instance_finalize()
callback of the parent gets called, so object_unparent() calls in
the callback will refer to objects that are already unparented, which
is semantically incorrect.
Signed-off-by: Akihiko Odaki <[email protected]>
Is this a qemu-stable material?
I don't think so. It's semantically incorrect but I don't see a
possibility that it causes a real problem. Cherry-picking it shouldn't
cause a harm though. Having this patch or not shouldn't make any
behavioral change.
Regards,
Akihiko Odaki
Please let me know if it is -- I'm *not* queuing it up for now.
Thanks,
/mjt
---
See also:
https://lore.kernel.org/qemu-devel/20250924-use-
[email protected]
---
hw/pci/shpc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
index aac6f2d03459..938602866d77 100644
--- a/hw/pci/shpc.c
+++ b/hw/pci/shpc.c
@@ -735,7 +735,6 @@ void shpc_free(PCIDevice *d)
if (!shpc) {
return;
}
- object_unparent(OBJECT(&shpc->mmio));
g_free(shpc->config);
g_free(shpc->cmask);
g_free(shpc->wmask);
---
base-commit: c85ba2d7a4056595166689890285105579db446a
change-id: 20251027-shpc-d71bb72d67af
Best regards,
--
Akihiko Odaki <[email protected]>
