From: Daniel Henrique Barboza <[email protected]>
The recently added Boston MIPS board selftest times out consistently in a
machine running 'make check-functional' with -j 16:
18/18 func-thorough+func-riscv64-thorough+thorough - qemu:func-riscv64-boston
TIMEOUT 120.09s killed by signal 15 SIGTERM
The reason is quite boring: it is testing too much stuff.
Note that functional tests aren't supposed to be used as stress tests,
e.g. it doesn't have to test every single corner case that might hit the
board. It is supposed to catch most common user ooopsies. A timeout, in
this context, is most likely to be considered something abnormal slowing
down the emulation, not a lack of CPU horsepower to run all the tests
before timeout.
Some of the tests claim to test odd CPU SMP numbers to either "ensures
proper core distribution across clusters" or "validating proper handling
of larger asymmetric SMP configurations". But there's no SMP/NUMA check
made anywhere after boot, so in the end we're just testing whether the
board is able to boot with 7/35 CPUs. As far as these tests are concerned
we could have a completely broken, but bootable, SMP topology with 7/35
CPUS, and we're oblivious about it.
Remove the 7 and 35 SMP tests, keeping the minimal CPUs (2) and maximum
(64) tests. With these changes we're now able to run the test with a
good TIMEOUT margin:
17/18 func-thorough+func-riscv64-thorough+thorough - qemu:func-riscv64-boston
OK 61.28s 3 subtests passed
Fixes: e71111e26b ("test/functional: Add test for boston-aia board")
Signed-off-by: Daniel Henrique Barboza <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Djordje Todorovic <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
tests/functional/riscv64/test_boston.py | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/tests/functional/riscv64/test_boston.py
b/tests/functional/riscv64/test_boston.py
index 2582df96f21..ec09544095e 100755
--- a/tests/functional/riscv64/test_boston.py
+++ b/tests/functional/riscv64/test_boston.py
@@ -66,25 +66,6 @@ def test_boston_boot_linux_min_cpus(self):
"""
self._boot_linux_test(smp_count=2)
- def test_boston_boot_linux_7_cpus(self):
- """
- Test Linux kernel boot with 7 CPUs
-
- 7 CPUs is a special configuration that tests odd CPU count
- handling and ensures proper core distribution across clusters.
- """
- self._boot_linux_test(smp_count=7)
-
- def test_boston_boot_linux_35_cpus(self):
- """
- Test Linux kernel boot with 35 CPUs
-
- 35 CPUs is a special configuration that tests a non-power-of-2
- CPU count above 32, validating proper handling of larger
- asymmetric SMP configurations.
- """
- self._boot_linux_test(smp_count=35)
-
def test_boston_boot_linux_max_cpus(self):
"""
Test Linux kernel boot with maximum supported CPU count (64)
--
2.52.0
