On Thu, Feb 5, 2026 at 8:22 PM Richard Henderson < [email protected]> wrote:
> On 2/6/26 03:26, Warner Losh wrote: > > From: Stacey Son <[email protected]> > > > > Add implementation of msgctl(2) syscall for System V message queue > control > > operations. Handles command translation and structure conversions for > > IPC_STAT/IPC_SET/IPC_RMID operations. > > > > Signed-off-by: Stacey Son <[email protected]> > > Signed-off-by: Warner Losh <[email protected]> > > --- > > bsd-user/bsd-misc.h | 53 > +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/bsd-user/bsd-misc.h b/bsd-user/bsd-misc.h > > index 81fdfd8351..27f4497d76 100644 > > --- a/bsd-user/bsd-misc.h > > +++ b/bsd-user/bsd-misc.h > > @@ -28,6 +28,12 @@ > > > > #include "qemu-bsd.h" > > > > +#ifdef MSGMAX > > +static int bsd_msgmax = MSGMAX; > > +#else > > +static int bsd_msgmax; > > +#endif > > (1) This isn't used in this patch, and probably generates a Werror. > Yes, but no actually: bsd-misc.c isn't in the build yet... However, it should be folded with later revs. I missed that in the prep. > (2) Does any supported FreeBSD version actually define MSGMAX anymore? > Grepping current source suggests one always has to probe at runtime. > Yes. That's true. I'll remove the #ifdef. there is a define in the kernel, but it's confined to sysv_msg.c file. > Anyway, if you move this item to the next patch, > Reviewed-by: Richard Henderson <[email protected]> > > for the rest of this one. > > r~ >
