On Fri, Feb 06, 2026 at 02:48:34PM +0100, Thomas Huth wrote: > On 07/01/2026 14.01, Daniel P. Berrangé wrote: > > The --quiet command is used with docker unless V=1 is passed to make, > > and as a result stdout from docker is never visible by default, making > > it hard to diagnose failures building / running containers. > > > > Meanwhile passing V=1 is undesirable as that makes the entire build > > system verbose. > > > > Introduce a $(DOCKER_V) make variable which is initialized from $(V) > > > > It is thus possible to display docker output without also enabling > > make verbose output. > > > > Signed-off-by: Daniel P. Berrangé <[email protected]> > > --- > > tests/docker/Makefile.include | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include > > index 7d4582b6a8..d58a280333 100644 > > --- a/tests/docker/Makefile.include > > +++ b/tests/docker/Makefile.include > > @@ -40,14 +40,14 @@ docker-qemu-src: $(DOCKER_SRC_COPY) > > docker-image-%: $(DOCKER_FILES_DIR)/%.docker > > $(call quiet-command, \ > > DOCKER_BUILDKIT=1 $(RUNC) build \ > > - $(if $V,,--quiet) \ > > + $(if $(DOCKER_V),,--quiet) \ > > Hmm, do we maybe want a > > DOCKER_V ?= $(V) > > earlier in this file, so that DOCKER_V gets enabled when running in normal > verbose mode, too?
I was on the fence about it. V=1 is traditionally focused on details of the commands being executed, rather than their output, but I don't mind much either way. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
