On 2026/02/06 6:57, Michael Tokarev wrote:
On 12/23/25 21:40, Joelle van Dyne wrote:
When `owner` == `mr`, `object_unparent` will crash:
object_unparent(mr) ->
object_property_del_child(mr, mr) ->
object_finalize_child_property(mr, name, mr) ->
object_unref(mr) ->
object_finalize(mr) ->
object_property_del_all(mr) ->
object_finalize_child_property(mr, name, mr) ->
object_unref(mr) ->
fail on g_assert(obj->ref > 0)
However, passing a different `owner` to `memory_region_init` is not
enough. `memory_region_ref` has an optimization where it takes a ref
only on the owner. It specifically warns against calling unparent on
the memory region. So we initialize the memory region first and then
patch in the owner with itself.
Signed-off-by: Joelle van Dyne <[email protected]>
This one is quite a bit confusing.
Is it a qemu-stable material?
I'm *not* picking it up automatically.
Yes, I think so. It should have had Cc.
Regards,
Akihiko Odaki
