On 2/6/26 03:26, Warner Losh wrote:
This is more of a toolchain than an OS issue, and all the toolchains are
headed to requiring this. There's nothing Linux specific about it.
Signed-off-by: Warner Losh <[email protected]>
---
common-user/safe-syscall.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common-user/safe-syscall.S b/common-user/safe-syscall.S
index 74f7e35694..2f714cfbe8 100644
--- a/common-user/safe-syscall.S
+++ b/common-user/safe-syscall.S
@@ -22,6 +22,6 @@
* assembly needs an executable stack and the whole QEMU binary will
* needlessly end up with one. This should be the last thing in this file.
*/
-#if defined(__linux__) && defined(__ELF__)
+#if defined(__ELF__)
.section .note.GNU-stack, "", %progbits
#endif
It feels like you dropped the actual subject line, letting the first line of the
description become the new subject. Perhaps
common-user: Drop __linux__ around .note.GNU-stack
Anyway,
Reviewed-by: Richard Henderson <[email protected]>
r~
