Reading DST_PITCH and SRC_PITCH on the Rage 128 is broken. The read handlers attempt to construct the value from pitch and tile bits in the register state but mistakenly AND them instead of ORing them. This means the pitch is always zero on read.
Signed-off-by: Chad Jablonski <[email protected]> Reviewed-by: BALATON Zoltan <[email protected]> --- hw/display/ati.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index 8438a77de0..777a6b0a2e 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -438,7 +438,7 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) case DST_PITCH: val = s->regs.dst_pitch; if (s->dev_id == PCI_DEVICE_ID_ATI_RAGE128_PF) { - val &= s->regs.dst_tile << 16; + val |= s->regs.dst_tile << 16; } break; case DST_WIDTH: @@ -468,7 +468,7 @@ static uint64_t ati_mm_read(void *opaque, hwaddr addr, unsigned int size) case SRC_PITCH: val = s->regs.src_pitch; if (s->dev_id == PCI_DEVICE_ID_ATI_RAGE128_PF) { - val &= s->regs.src_tile << 16; + val |= s->regs.src_tile << 16; } break; case DP_BRUSH_BKGD_CLR: -- 2.52.0
