I have sent a cleanup patch: https://mail.gnu.org/archive/html/qemu-devel/2026-02/msg00800.html ([email protected])
Thanks, Jim On Tue, Feb 3, 2026 at 9:44 PM Jim Shu <[email protected]> wrote: > > Sorry for the late reply. > Yes, I can send a cleanup patch soon to fix the issue Richard mentioned, > thanks! > > Thanks, > Jim > > > On Tue, Feb 3, 2026 at 6:47 PM Philippe Mathieu-Daudé <[email protected]> > wrote: > > > > On 3/2/26 02:15, Richard Henderson wrote: > > > On 1/29/26 01:23, Jim Shu wrote: > > >> To let io_prepare() function use the multiple members in > > >> CPUTLBEntryFull struct, send the full struct instead of 'xlat_section' > > >> member as the argument. > > >> > > >> It is the preliminary patch of next commit. > > >> > > >> Signed-off-by: Jim Shu <[email protected]> > > >> --- > > >> accel/tcg/cputlb.c | 14 +++++++------- > > >> 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > >> static MemoryRegionSection * > > >> -io_prepare(hwaddr *out_offset, CPUState *cpu, hwaddr xlat, > > >> +io_prepare(hwaddr *out_offset, CPUState *cpu, CPUTLBEntryFull *full, > > >> MemTxAttrs attrs, vaddr addr, uintptr_t retaddr) > > >> { > > >> MemoryRegionSection *section; > > >> hwaddr mr_offset; > > >> - section = iotlb_to_section(cpu, xlat, attrs); > > >> - mr_offset = (xlat & TARGET_PAGE_MASK) + addr; > > >> + section = iotlb_to_section(cpu, full->xlat_section, attrs); > > >> + mr_offset = (full->xlat_section & TARGET_PAGE_MASK) + addr; > > > > > > attrs is also present in CPUTLBEntryFull; you can also drop that > > > parameter. > > > > Jim, now that this patch got merged (commit 94c6e9cf044), do you mind > > sending a cleanup patch? > > > > Thanks, > > > > Phil.
