On 2/2/26 20:25, Pierrick Bouvier wrote:
My initial testing showed a 50% slow down, which was more than
surprising. After profiling, the extra time is spent here:
https://github.com/qemu/qemu/
blob/587f4a1805c83a4e1d59dd43cb14e0a834843d1d/target-info.c#L30
When we merged target-info, there have been several versions over a long
time, and I was 100% sure we were updating the target_info structure,
instead of reparsing the target_name every time. Unfortunately, that's
not the case. I'll fix that.
We (Richard, you, myself) knew this patch was bad performance wise, but
back then it was decided to be good enough for the first conversion of
build-time target specific definitions to runtime methods.
As a second step, Richard asked for the target-info.c file to get
absorbed with page-vary-common.c, compiling it with CFLAG=-fno-lto.
This wasn't a priority until TargetInfo API got involved in hot path.
