On 2/2/26 16:36, Anton Johansson wrote:
On 22/01/26, Philippe Mathieu-Daudé wrote:
Introduce mo_endian_env() which returns the endian MemOp
from the vCPU env pointer. Keep it hardcoded as MO_TE.
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
target/ppc/internal.h | 6 ++++++
target/ppc/mem_helper.c | 18 +++++++++---------
target/ppc/tcg-excp_helper.c | 2 +-
3 files changed, 16 insertions(+), 10 deletions(-)
Minor comment but the difference between mo_endian_env() and ppc_code_endian()
is a bit unclear from the names. I think especially since
mo_endian_env() is used in ppc_ld_code() later on. Maybe
ppc_code_endian() -> ppc_disas_endian() || ppc_tb_endian()?
Or mo_endian_env() -> ppc_data_endian()?
Regardless of namechange, just throwing out my 2c
Reviewed-by: Anton Johansson <[email protected]>
Thanks!
